Ok, I didn't look at the code very closely just wanted to solve a memory corruption problem. Can you make the change and perhaps add an assert that i isn't out of bounds in the layout code?<div><br></div><div> - Daniel<br>
<br><div class="gmail_quote">On Wed, Apr 8, 2009 at 1:41 PM, Fariborz Jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
On Apr 8, 2009, at 1:18 PM, Daniel Dunbar wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ddunbar<br>
Date: Wed Apr  8 15:18:15 2009<br>
New Revision: 68634<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=68634&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=68634&view=rev</a><br>
Log:<br>
Fix buffer overrun when laying out synthesized ivars.<br>
<br>
Modified:<br>
   cfe/trunk/lib/AST/ASTContext.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/ASTContext.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=68634&r1=68633&r2=68634&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=68634&r1=68633&r2=68634&view=diff</a><br>

<br>
=<br>
=<br>
=<br>
=<br>
=<br>
=<br>
=<br>
=<br>
======================================================================<br>
--- cfe/trunk/lib/AST/ASTContext.cpp (original)<br>
+++ cfe/trunk/lib/AST/ASTContext.cpp Wed Apr  8 15:18:15 2009<br>
@@ -679,7 +679,8 @@<br>
  // Allocate and assign into ASTRecordLayouts here.  The "Entry" reference can<br>
  // be invalidated (dangle) if the ASTRecordLayouts hashtable is inserted into.<br>
  ASTRecordLayout *NewEntry = NULL;<br>
-  unsigned FieldCount = D->ivar_size();<br>
+  unsigned FieldCount =<br>
+    D->ivar_size() + std::distance(D->prop_begin(), D->prop_end());<br>
</blockquote>
<br></div>
This is the upper bound and is  harmless. An accurate count<br>
is preferred though to assert more strictly in:<br>
<br>
void SetFieldOffset(unsigned FieldNo, uint64_t Offset) {<br>
    assert (FieldNo < FieldCount && "Invalid Field No");<br>
    FieldOffsets[FieldNo] = Offset;<br>
  }<br><font color="#888888">
<br>
<br>
- Fariborz</font><div><div></div><div class="h5"><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
  if (ObjCInterfaceDecl *SD = D->getSuperClass()) {<br>
    FieldCount++;<br>
    const ASTRecordLayout &SL = getASTObjCInterfaceLayout(SD);<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote>
<br>
</div></div></blockquote></div><br></div>