Should we really allow this? If we only see this in one obscure case it seems like it would be better to reject this by default.<div><br></div><div> - Daniel<br><br><div class="gmail_quote">On Sat, Apr 4, 2009 at 5:53 PM, Chris Lattner <span dir="ltr"><<a href="mailto:sabre@nondot.org">sabre@nondot.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Author: lattner<br>
Date: Sat Apr  4 19:52:59 2009<br>
New Revision: 68434<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=68434&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=68434&view=rev</a><br>
Log:<br>
GCC compatibility: gcc allows applying va_args to const<br>
va_lists for some reason.  This fixes rdar://6726818<br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/SemaExpr.cpp<br>
    cfe/trunk/test/Sema/varargs.c<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=68434&r1=68433&r2=68434&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=68434&r1=68433&r2=68434&view=diff</a><br>

<br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Sat Apr  4 19:52:59 2009<br>
@@ -4724,7 +4724,10 @@<br>
   Expr *E = static_cast<Expr*>(expr.get());<br>
   UsualUnaryConversions(E);<br>
<br>
-  if (CheckAssignmentConstraints(VaListType, E->getType()) != Compatible)<br>
+  AssignConvertType ConvResult =<br>
+    CheckAssignmentConstraints(VaListType, E->getType());<br>
+  if (ConvResult != Compatible &&<br>
+      ConvResult != CompatiblePointerDiscardsQualifiers)<br>
     return ExprError(Diag(E->getLocStart(),<br>
                          diag::err_first_argument_to_va_arg_not_of_type_va_list)<br>
       << E->getType() << E->getSourceRange());<br>
<br>
Modified: cfe/trunk/test/Sema/varargs.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/varargs.c?rev=68434&r1=68433&r2=68434&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/varargs.c?rev=68434&r1=68433&r2=68434&view=diff</a><br>

<br>
==============================================================================<br>
--- cfe/trunk/test/Sema/varargs.c (original)<br>
+++ cfe/trunk/test/Sema/varargs.c Sat Apr  4 19:52:59 2009<br>
@@ -60,3 +60,10 @@<br>
   int *x = &__builtin_va_arg(ap, int); // expected-error {{address expression must be an lvalue or a function designator}}<br>
   __builtin_va_end(ap);<br>
 }<br>
+<br>
+// rdar://6726818<br>
+void f8() {<br>
+  const __builtin_va_list args2;<br>
+  (void)__builtin_va_arg(args2, int);<br>
+}<br>
+<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>