<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 18, 2009, at 10:42 PM, Daniel Dunbar wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On Wed, Mar 18, 2009 at 9:46 PM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com">clattner@apple.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im"> On Mar 18, 2009, at 4:34 PM, Daniel Dunbar wrote:<br> <br> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Author: ddunbar<br> Date: Wed Mar 18 18:34:15 2009<br> New Revision: 67256<br> <br> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=67256&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=67256&view=rev</a><br> Log:<br> Driver: Resolve program path for "cp" (used as part of transparent gcc<br> PCH support).<br> </blockquote> <br></div> Does the driver really need to run cp? Why can't it copy files itself?<font color="#888888"></font></blockquote><div><br>No; this is a hack which I hope to get rid of, I just haven't investigated how important it is. In general the driver should not make new files the user didn't request; for now this is a convenient hack which allows transparent PTH support, however.<br> <br>That said, if we are copying the file, calling cp isn't the worst thing in the world and exposes the driver's actions to the user. Do we have a robust copy file implementation?<br>ddunbar@frank:~$ wc -l ~/public/coreutils-6.10/src/cp.c<br> 1118 /home/ddunbar/public/coreutils-6.10/src/cp.c<br></div></div></blockquote></div><br><div>I guess this problem has been defined-away by the new -include-pth option.</div></body></html>