Hi Mike,<br><br>This isn't right; the Driver library shouldn't have these things embedded in it. The reason I left it blank was because I was going to do try and provide a proper version number derived from SVN (at some point). This is something I personally would really like and some other users have requested.<br>
<br>Also, the use of TARGET_TRIPLE isn't necessary; the Driver already knows what host it is on (DefaultHostTriple), although probably it should just query the default tool chain for this information.<br><br> - Daniel<br>
<br><div class="gmail_quote">On Wed, Mar 18, 2009 at 7:00 AM, Mike Stump <span dir="ltr"><<a href="mailto:mrs@apple.com">mrs@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Author: mrs<br>
Date: Wed Mar 18 09:00:02 2009<br>
New Revision: 67204<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=67204&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=67204&view=rev</a><br>
Log:<br>
Improve version number.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Driver/Driver.cpp   (contents, props changed)<br>
    cfe/trunk/lib/Driver/Makefile<br>
<br>
Modified: cfe/trunk/lib/Driver/Driver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Driver.cpp?rev=67204&r1=67203&r2=67204&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Driver.cpp?rev=67204&r1=67203&r2=67204&view=diff</a><br>

<br>
==============================================================================<br>
--- cfe/trunk/lib/Driver/Driver.cpp (original)<br>
+++ cfe/trunk/lib/Driver/Driver.cpp Wed Mar 18 09:00:02 2009<br>
@@ -212,11 +212,22 @@<br>
 }<br>
<br>
 void Driver::PrintVersion() const {<br>
-  // FIXME: Get a reasonable version number.<br>
+  static char buf[] = "$URL$";<br>
+  char *zap = strstr(buf, "/lib/Driver");<br>
+  if (zap)<br>
+    *zap = 0;<br>
+  zap = strstr(buf, "/clang/tools/clang");<br>
+  if (zap)<br>
+    *zap = 0;<br>
+  const char *vers = buf+10;<br>
<br>
   // FIXME: The following handlers should use a callback mechanism, we<br>
   // don't know what the client would like to do.<br>
-  llvm::errs() << "ccc version 1.0" << "\n";<br>
+  llvm::errs() << "ccc version 1.0 (" << vers << ")" << "\n";<br>
+  // FIXME: Add cmake support and remove #ifdef<br>
+#ifdef TARGET_TRIPLE<br>
+  llvm::errs() << "Target: " << TARGET_TRIPLE << "\n";<br>
+#endif<br>
 }<br>
<br>
 bool Driver::HandleImmediateArgs(const Compilation &C) {<br>
<br>
Propchange: cfe/trunk/lib/Driver/Driver.cpp<br>
<br>
------------------------------------------------------------------------------<br>
    svn:keywords = URL<br>
<br>
Modified: cfe/trunk/lib/Driver/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Makefile?rev=67204&r1=67203&r2=67204&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Makefile?rev=67204&r1=67203&r2=67204&view=diff</a><br>

<br>
==============================================================================<br>
--- cfe/trunk/lib/Driver/Makefile (original)<br>
+++ cfe/trunk/lib/Driver/Makefile Wed Mar 18 09:00:02 2009<br>
@@ -12,7 +12,7 @@<br>
 BUILD_ARCHIVE = 1<br>
 CXXFLAGS = -fno-rtti<br>
<br>
-CPPFLAGS += -I$(PROJ_SRC_DIR)/../../include -I$(PROJ_OBJ_DIR)/../../include<br>
+CPPFLAGS += -I$(PROJ_SRC_DIR)/../../include -I$(PROJ_OBJ_DIR)/../../include -DTARGET_TRIPLE='"$(TARGET_TRIPLE)"'<br>
<br>
 include $(LEVEL)/Makefile.common<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>