<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">It turned out just to be an optimization. It does less work, not more. Do you have a suggestion of what would be a good test case for this? Testing this has more to do with the browser behavior than the emitted HTML.<br><div><br><div><div>On Mar 18, 2009, at 1:04 PM, Daniel Dunbar wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Test case for this isn't out of the question?<br><br> - Daniel<br><br><div class="gmail_quote">On Wed, Mar 18, 2009 at 11:47 AM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Author: kremenek<br> Date: Wed Mar 18 13:47:46 2009<br> New Revision: 67221<br> <br> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=67221&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=67221&view=rev</a><br> Log:<br> HTML rewriter: Don't replace tabs with spaces by default.<br> <br> Modified:<br> cfe/trunk/include/clang/Rewrite/HTMLRewrite.h<br> <br> Modified: cfe/trunk/include/clang/Rewrite/HTMLRewrite.h<br> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Rewrite/HTMLRewrite.h?rev=67221&r1=67220&r2=67221&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Rewrite/HTMLRewrite.h?rev=67221&r1=67220&r2=67221&view=diff</a><br> <br> ==============================================================================<br> --- cfe/trunk/include/clang/Rewrite/HTMLRewrite.h (original)<br> +++ cfe/trunk/include/clang/Rewrite/HTMLRewrite.h Wed Mar 18 13:47:46 2009<br> @@ -52,14 +52,14 @@<br> /// EscapeText - HTMLize a specified file so that special characters are<br> /// are translated so that they are not interpreted as HTML tags.<br> void EscapeText(Rewriter& R, FileID FID,<br> - bool EscapeSpaces = false, bool ReplacesTabs = true);<br> + bool EscapeSpaces = false, bool ReplaceTabs = false);<br> <br> /// EscapeText - HTMLized the provided string so that special characters<br> /// in 's' are not interpreted as HTML tags. Unlike the version of<br> /// EscapeText that rewrites a file, this version by default replaces tabs<br> /// with spaces.<br> std::string EscapeText(const std::string& s,<br> - bool EscapeSpaces = false, bool ReplaceTabs = true);<br> + bool EscapeSpaces = false, bool ReplaceTabs = false);<br> <br> void AddLineNumbers(Rewriter& R, FileID FID);<br> <br> <br> <br> _______________________________________________<br> cfe-commits mailing list<br> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br> </blockquote></div><br></blockquote></div><br></div></body></html>