Hi Fariborz,<br><br>Its probably worth having an assert that the type is a pointer type if there is a mismatch. Sema shouldn't let this through for other cases (like float -> int) but its worth making this clear.<br>
<br> - Daniel<br><br><div class="gmail_quote">On Tue, Mar 3, 2009 at 11:49 AM, Fariborz Jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Author: fjahanian<br>
Date: Tue Mar  3 12:49:40 2009<br>
New Revision: 65955<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=65955&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=65955&view=rev</a><br>
Log:<br>
Fixed an ir-gen bug in syntheszing a getter function<br>
with property type which does not match its ivar and<br>
in -fobjc-gc-only mode!<br>
<br>
Added:<br>
    cfe/trunk/test/CodeGenObjC/objc2-retain-codegen.m<br>
Modified:<br>
    cfe/trunk/lib/CodeGen/CGObjC.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjC.cpp?rev=65955&r1=65954&r2=65955&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjC.cpp?rev=65955&r1=65954&r2=65955&view=diff</a><br>

<br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGObjC.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGObjC.cpp Tue Mar  3 12:49:40 2009<br>
@@ -205,9 +205,13 @@<br>
     if (hasAggregateLLVMType(Ivar->getType())) {<br>
       EmitAggregateCopy(ReturnValue, LV.getAddress(), Ivar->getType());<br>
     }<br>
-    else<br>
-      EmitReturnOfRValue(EmitLoadOfLValue(LV, Ivar->getType()),<br>
-                                          PD->getType());<br>
+    else {<br>
+      CodeGenTypes &Types = CGM.getTypes();<br>
+      RValue RV = EmitLoadOfLValue(LV, Ivar->getType());<br>
+      RV = RValue::get(Builder.CreateBitCast(RV.getScalarVal(),<br>
+                       Types.ConvertType(PD->getType())));<br>
+      EmitReturnOfRValue(RV, PD->getType());<br>
+    }<br>
   }<br>
<br>
   FinishFunction();<br>
<br>
Added: cfe/trunk/test/CodeGenObjC/objc2-retain-codegen.m<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/objc2-retain-codegen.m?rev=65955&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/objc2-retain-codegen.m?rev=65955&view=auto</a><br>

<br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenObjC/objc2-retain-codegen.m (added)<br>
+++ cfe/trunk/test/CodeGenObjC/objc2-retain-codegen.m Tue Mar  3 12:49:40 2009<br>
@@ -0,0 +1,12 @@<br>
+// RUN: clang -triple x86_64-unknown-unknown -fobjc-gc-only -emit-llvm -o %t %s<br>
+<br>
+@interface I0 {<br>
+  I0 *_f0;<br>
+}<br>
+@property (retain) id p0;<br>
+@end<br>
+<br>
+@implementation I0<br>
+  @synthesize p0 = _f0;<br>
+@end<br>
+<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>