<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Feb 16, 2009, at 8:51 AM, Ben Laurie wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; ">On Mon, Feb 16, 2009 at 4:48 PM, Ben Laurie <<a href="mailto:benl@google.com">benl@google.com</a>> wrote:<br><blockquote type="cite">On Mon, Feb 16, 2009 at 4:26 PM, Ted Kremenek <<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>> wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite">On Feb 16, 2009, at 1:19 AM, Ben Laurie <<a href="mailto:benl@google.com">benl@google.com</a>> wrote:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">On Mon, Feb 16, 2009 at 4:54 AM, Ted Kremenek <<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>> wrote:<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Author: kremenek<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Date: Sun Feb 15 22:54:20 2009<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">New Revision: 64627<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=64627&view=rev">http://llvm.org/viewvc/llvm-project?rev=64627&view=rev</a><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Log:<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Do not register 'RangeConstraintManager' as the default<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">ConstraintManager.<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">I should note that this didn't work, by the way.<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Hi Ben,<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">I'm more than happy to fix my mistakes, but your comment doesn't contain any<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">actionable information. Can you clarify what you mean by "this didn't<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">work"?. That could mean a variety of issues. Are you seeing that<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">RangeConstraintManager is not being used at all now (despite whatever<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">options you pass to the command line)? If that is the case, I suspect the<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">analagous line in BasicConstraintManager.c needs to be removed as well (I<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">can't tell right now if there is one since I'm not near an editor).<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">What i meant was that adding<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">RegisterConstraintManager X(CreateRangeConstraintManager);<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">did not cause the RangeConstraintManager to be used when there was no<br></blockquote><blockquote type="cite">command-line option to enable it. I did not investigate further since<br></blockquote><blockquote type="cite">this is clearly the wrong way to do it.<br></blockquote><br>BTW, it seemed to me that this mechanism would be more useful if it<br>registered the constraint manager and some string identifying it, and<br>then used a command-line option to select one of the registered<br>managers...</span></blockquote></div><br><div>I agree, although the mechanism has to be general enough that the individual ConstraintManagers don't assume that they are being used from a command-line driver. The logic you mention would mostly go into AnalysisConsumer (which is driver specific). Feel free to take a stab at it if you are interested.</div></body></html>