<br><br><div class="gmail_quote">On Tue, Nov 25, 2008 at 2:58 AM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Zhongxing,<br>
<br>
Looks great.  One thing we should start doing is better documenting these utility methods with doxygen comments.  We have a bunch of variants now of methods like 'MakeVal', so it's probably worth investing some time in providing some documentation as we add these methods.</blockquote>
<div><br>Okay. But are these utility methods self-documented?<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><font color="#888888">
<br>
Ted</font><div><div></div><div class="Wj3C7c"><br>
<br>
On Nov 24, 2008, at 1:38 AM, Zhongxing Xu wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Author: zhongxingxu<br>
Date: Mon Nov 24 03:38:21 2008<br>
New Revision: 59956<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=59956&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=59956&view=rev</a><br>
Log:<br>
Add utility methods.<br>
<br>
Modified:<br>
   cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h<br>
   cfe/trunk/lib/Analysis/SVals.cpp<br>
<br>
Modified: cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h?rev=59956&r1=59955&r2=59956&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h?rev=59956&r1=59955&r2=59956&view=diff</a><br>

<br>
==============================================================================<br>
--- cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h (original)<br>
+++ cfe/trunk/include/clang/Analysis/PathSensitive/SVals.h Mon Nov 24 03:38:21 2008<br>
@@ -174,12 +174,17 @@<br>
  static NonLoc MakeVal(BasicValueFactory& BasicVals, unsigned X,<br>
                        bool isUnsigned);<br>
<br>
+  static NonLoc MakeVal(BasicValueFactory& BasicVals, uint64_t X,<br>
+                        unsigned BitWidth, bool isUnsigned);<br>
+<br>
  static NonLoc MakeVal(BasicValueFactory& BasicVals, uint64_t X, QualType T);<br>
<br>
  static NonLoc MakeVal(BasicValueFactory& BasicVals, IntegerLiteral* I);<br>
<br>
  static NonLoc MakeVal(BasicValueFactory& BasicVals, const llvm::APInt& I,<br>
                        bool isUnsigned);<br>
+<br>
+  static NonLoc MakeVal(BasicValueFactory& BasicVals, const llvm::APSInt& I);<br>
<br>
  static NonLoc MakeIntTruthVal(BasicValueFactory& BasicVals, bool b);<br>
<br>
<br>
Modified: cfe/trunk/lib/Analysis/SVals.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/SVals.cpp?rev=59956&r1=59955&r2=59956&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/SVals.cpp?rev=59956&r1=59955&r2=59956&view=diff</a><br>

<br>
==============================================================================<br>
--- cfe/trunk/lib/Analysis/SVals.cpp (original)<br>
+++ cfe/trunk/lib/Analysis/SVals.cpp Mon Nov 24 03:38:21 2008<br>
@@ -248,6 +248,11 @@<br>
                                                isUnsigned));<br>
}<br>
<br>
+NonLoc NonLoc::MakeVal(BasicValueFactory& BasicVals, uint64_t X,<br>
+                       unsigned BitWidth, bool isUnsigned) {<br>
+  return nonloc::ConcreteInt(BasicVals.getValue(X, BitWidth, isUnsigned));<br>
+}<br>
+<br>
NonLoc NonLoc::MakeVal(BasicValueFactory& BasicVals, uint64_t X, QualType T) {<br>
  return nonloc::ConcreteInt(BasicVals.getValue(X, T));<br>
}<br>
@@ -263,6 +268,10 @@<br>
  return nonloc::ConcreteInt(BasicVals.getValue(I, isUnsigned));<br>
}<br>
<br>
+NonLoc NonLoc::MakeVal(BasicValueFactory& BasicVals, const llvm::APSInt& I) {<br>
+  return nonloc::ConcreteInt(BasicVals.getValue(I));<br>
+}<br>
+<br>
NonLoc NonLoc::MakeIntTruthVal(BasicValueFactory& BasicVals, bool b) {<br>
  return nonloc::ConcreteInt(BasicVals.getTruthValue(b));<br>
}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote>
<br>
</div></div></blockquote></div><br>