<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div></div><div><br></div><div>I just move the operators out of the class in a straightforward way. With this patch, I get build errors like these:</div><div><br></div><div><div><font class="Apple-style-span" face="Courier">Lexer.cpp: In function ‘char DecodeTrigraphChar(const char*, clang::Lexer*)’:</font></div><div><font class="Apple-style-span" face="Courier">Lexer.cpp:352: error: no match for ‘operator<<’ in ‘clang::Lexer::Diag(const char*, unsigned int) const((CP - 2u), 9u) << std::operator+(const std::basic_string<_CharT, _Traits, _Alloc>&, _CharT) [with _Char</font></div><div><font class="Apple-style-span" face="Courier">T = char, _Traits = std::char_traits<char>, _Alloc = std::allocator<char>](((int)Res))’</font></div><div><font class="Apple-style-span" face="Courier">/Users/sabre/llvm/tools/clang/lib/Lex/../../include/clang/Basic/Diagnostic.h:366: note: candidates are: clang::DiagnosticInfo& clang::operator<<(clang::DiagnosticInfo&, const std::string&)</font></div><div><font class="Apple-style-span" face="Courier">/Users/sabre/llvm/tools/clang/lib/Lex/../../include/clang/Basic/Diagnostic.h:371: note: clang::DiagnosticInfo& clang::operator<<(clang::DiagnosticInfo&, const char*)</font></div><div><font class="Apple-style-span" face="Courier">/Users/sabre/llvm/tools/clang/lib/Lex/../../include/clang/Basic/Diagnostic.h:376: note: clang::DiagnosticInfo& clang::operator<<(clang::DiagnosticInfo&, int)</font></div><div><font class="Apple-style-span" face="Courier">/Users/sabre/llvm/tools/clang/lib/Lex/../../include/clang/Basic/Diagnostic.h:381: note: clang::DiagnosticInfo& clang::operator<<(clang::DiagnosticInfo&, unsigned int)</font></div><div><font class="Apple-style-span" face="Courier">/Users/sabre/llvm/tools/clang/lib/Lex/../../include/clang/Basic/Diagnostic.h:386: note: clang::DiagnosticInfo& clang::operator<<(clang::DiagnosticInfo&, const clang::IdentifierInfo*)</font></div><div><font class="Apple-style-span" face="Courier">/Users/sabre/llvm/tools/clang/lib/Lex/../../include/clang/Basic/Diagnostic.h:392: note: clang::DiagnosticInfo& clang::operator<<(clang::DiagnosticInfo&, const clang::SourceRange&)</font></div><br></div><div>This is the source line:</div><div><div><div>Lexer *L; char Res;</div></div><div>...</div><div> L->Diag(CP-2, diag::trigraph_converted) << std::string()+Res;</div> <br></div><div>This is a good point where we can step back and look at the amazing awfulness of this diagnostic. It's 'pretty' printing out the expression in question, in a horribly mangled form. Then it dumps out a candidate list, but manages to not tell me the types that it actually *has* on the LHS/RHS of the <<. In practice, I think the problem is that Diag is returning a temporary:</div><div><br></div><div>class Lexer {</div><div>...</div><div><div> DiagnosticInfo Diag(const char *Loc, unsigned DiagID) const;</div> </div><div><br></div><div>and this isn't matching as the non-constant reference form of <<. Imagine if it told me that it had near match! :)</div><div><br></div><div>All bitching about diagnostics aside, how should I go about fixing this? Should have hack the overloads to use const references and cast away the const? Do you have a better suggestion?</div><div><br></div><div>-Chris</div><div><br></div><div><br></div></body></html>