<br><br><div class="gmail_quote">On Fri, Oct 24, 2008 at 8:55 AM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div style=""><br><div><div><div></div><div class="Wj3C7c"><div>On Oct 23, 2008, at 5:52 PM, Zhongxing Xu wrote:</div><br><blockquote type="cite"><br><br><div class="gmail_quote">On Fri, Oct 24, 2008 at 8:09 AM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com" target="_blank">kremenek@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><br><div><div><div></div><div><div>On Oct 22, 2008, at 9:21 PM, Zhongxing Xu wrote:</div><br></div></div><blockquote type="cite"><div><div></div><div>New patch attached.<br><br>
<div class="gmail_quote">On Thu, Oct 23, 2008 at 9:28 AM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com" target="_blank">kremenek@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><br>
On Oct 22, 2008, at 6:26 PM, Zhongxing Xu wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
This assertion will always be true. Did you mean assert(false && "...")?<br>
<br>
No, I just don't want the program to crash when things happen, but also put reminder there.<br>
<br>
Then it's not really an assertion. Just use a comment.<br>
<br>
OK. I'll make it a comment. But I do see others doing this in Clang.<br>
</blockquote>
<br></div>
Those places are probably miswritten assertions. When you spot them feel free to bring it to everyone's attention or submit a patch.<br>
<br>
Thanks Zhongxing!<br>
</blockquote></div><br>
</div></div><span><element2.patch></span></blockquote></div><br><div><div>+SVal RegionStoreManager::ArrayToPointer(SVal Array) {</div><div>+ const MemRegion* ArrayR = cast<loc::MemRegionVal>(&Array)->getRegion();</div>
<div>+</div><div>+ const VarDecl* D = cast<VarRegion>(ArrayR)->getDecl();</div><div>+</div><div>+ const ConstantArrayType* CAT = </div><div>+ cast<ConstantArrayType>(D->getType().getTypePtr());</div>
<div><br></div><div>Won't this cast<> fail for VLAs?</div></div></div></blockquote><div><br>I fix with this:<br><br> +SVal RegionStoreManager::ArrayToPointer(SVal Array) {<br>+ const MemRegion* ArrayR = cast<loc::MemRegionVal>(&Array)->getRegion();<br>
+<br>+ const VarDecl* D = cast<VarRegion>(ArrayR)->getDecl();<br>+<br>+ if (const ConstantArrayType* CAT = <br>+ dyn_cast<ConstantArrayType>(D->getType().getTypePtr())) {<br>+<br>+ BasicValueFactory& BasicVals = StateMgr.getBasicVals();<br>
+ <br>+ nonloc::ConcreteInt Idx(BasicVals.getValue(0, CAT->getSize().getBitWidth(),<br>+ false));<br>+<br>+ ElementRegion* ER = MRMgr.getElementRegion(Idx, ArrayR);<br>
+ <br>+ return loc::MemRegionVal(ER);<br>+ }<br>+<br>+ return Array;<br>+}</div></div></blockquote><div><br></div></div></div>Looks good, except you need a return value for the VLA case (UnknownVal()?).</div></div>
</blockquote><div><br>I return the original Array. Did you miss the last line?<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div style=""><div></div><div class="Ih2E3d"><div><br></div><div><blockquote type="cite"><div class="gmail_quote"><div><span style="color: rgb(0, 0, 0);">I am sure we'll iterate on this when we decide to handle VLAs. </span></div>
</div>
</blockquote><br></div></div><div>Definitely; we just don't want it to crash in the meantime. ;-)</div><br></div></blockquote></div><br>