<div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><br>
+BUILTIN(__builtin_ia32_vec_set_v2di, "V2LLV2LLLLi", "")</blockquote><div><br></div><div>This should be "V2LLiV2LLiLLi"?</div><div><br></div><div>Also, could you add these to tests/Codegen/x86-builtins.c? It's currently XFAIL so it doesn't do much but conceivably it would catch errors like the above.</div>
<div><br></div><div> - Daniel</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><br>
+BUILTIN(__builtin_ia32_insertps128, "V4fV4fV4fi", "")<br>
<br>
 BUILTIN(__builtin_ia32_movqv4si, "V4iV4i", "")<br>
 BUILTIN(__builtin_ia32_loadlv4si, "V4iV2i*", "")<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=57563&r1=57562&r2=57563&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=57563&r1=57562&r2=57563&view=diff</a><br>

<br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGBuiltin.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGBuiltin.cpp Wed Oct 15 01:18:34 2008<br>
@@ -902,6 +902,10 @@<br>
   case X86::BI__builtin_ia32_vec_set_v4hi:<br>
   case X86::BI__builtin_ia32_vec_set_v8hi:<br>
     return Builder.CreateInsertElement(Ops[0], Ops[1], Ops[2], "pinsrw");<br>
+  case X86::BI__builtin_ia32_vec_set_v4si:<br>
+    return Builder.CreateInsertElement(Ops[0], Ops[1], Ops[2], "pinsrd");<br>
+  case X86::BI__builtin_ia32_vec_set_v2di:<br>
+    return Builder.CreateInsertElement(Ops[0], Ops[1], Ops[2], "pinsrq");<br>
   case X86::BI__builtin_ia32_andps:<br>
   case X86::BI__builtin_ia32_andpd:<br>
   case X86::BI__builtin_ia32_andnps:<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>