<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 20, 2008, at 10:33 PM, Eli Friedman wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; ">Author: efriedma<br>Date: Wed May 21 00:33:10 2008<br>New Revision: 51364<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=51364&view=rev">http://llvm.org/viewvc/llvm-project?rev=51364&view=rev</a><br>Log:<br>Fix the destruction "properly" in the sense that we actually destroy the<span class="Apple-converted-space"> </span><br>ASTs. This is a hack, but I haven't considered how we really<span class="Apple-converted-space"> </span><br>want to do this.</span></blockquote></div><br><div>I agree that this is a hack. TranslationUnit currently has dual modes where it can own certain objects and delete them in its dstor and not own them and not delete them. I think this helps create bugs like these. We definitely need a better design.</div></body></html>