<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 30, 2007, at 7:40 PM, Christopher Lamb wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div><blockquote type="cite"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><span class="Apple-style-span" style="-webkit-text-stroke-width: -1px; "><font class="Apple-style-span" face="Monaco" size="2">+</font><font class="Apple-style-span" face="Monaco" size="2"> <span class="Apple-converted-space"> </span></font><font class="Apple-style-span" face="Monaco" size="2">case BinaryOperator::Div:</font></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">+</span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; "> <span class="Apple-converted-space"> </span></span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">if (llvm::APFloat::opOK !=</span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; "> </span></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">+</span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; "> <span class="Apple-converted-space"> </span></span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">Result.divide(RHS, llvm::APFloat::rmNearestTiesToEven)) {</span></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">+</span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; "> <span class="Apple-converted-space"> </span></span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">if (!isEvaluated) break;</span></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">+</span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; "> <span class="Apple-converted-space"> </span></span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">if (Loc) *Loc = getLocStart();</span></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">+</span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; "> <span class="Apple-converted-space"> </span></span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">return false;</span></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">+</span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; "> <span class="Apple-converted-space"> </span></span></font><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">}</span></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; "><br class="khtml-block-placeholder"></span></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px; ">It would be "nice" if this reported diagnostics for overflow etc as warnings.</span></font></div></blockquote></div><div><br class="webkit-block-placeholder"></div><div>This is in Expr.cpp and it's called from CodeGen, how can I get the diagnostics object here?</div></span></blockquote></div><br><div>Ah, we don't want to emit a diagnostic from CodeGen. However, the same routine should be called by sema, to verify that the initializer for a global is constant. We want sema to be able to emit a warning/error and codegen to not, but both to get the result value.</div><div><br class="webkit-block-placeholder"></div><div>The best way to do this is probably something like what <span class="Apple-style-span" style="font-family: Monaco; font-size: 10px; ">isIntegerConstantExpr does. If "Loc" is specified, it is filled in with the location of the diagnostic. The missing piece is that we want a diagid to report as well. For example something like this:</span></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"><br class="webkit-block-placeholder"></span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"> SourceLocation Loc;</span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"> diag::<span class="Apple-style-span" style="color: rgb(38, 71, 75); ">kind ConstDiag = 0;</span></span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"> bool isConst = Init->isRealFloatingConstantExpr(Result,Ctx, &Loc, &ConstDiag);</span></font></div><div><br></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"> if (<span class="Apple-style-span" style="color: rgb(38, 71, 75); ">ConstDiag)</span></span></font></div><div><font class="Apple-style-span" color="#26474B" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"> Diag(Loc, ConstDiag, Init->getSourceRange());</span></font></div><div><font class="Apple-style-span" color="#26474B" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"><br class="webkit-block-placeholder"></span></font></div><div><font class="Apple-style-span" color="#26474B" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;">or something like that. Codegen would just not pass in, or would ignore, the diagnostic info.</span></font></div><div><font class="Apple-style-span" color="#26474B" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"><br class="webkit-block-placeholder"></span></font></div><div><font class="Apple-style-span" color="#26474B" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;">Does that seem reasonable?</span></font></div><div><font class="Apple-style-span" color="#26474B" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"><br class="webkit-block-placeholder"></span></font></div><div><font class="Apple-style-span" color="#26474B" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;">-Chris</span></font></div><div><br class="webkit-block-placeholder"></div></body></html>