<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><DIV><DIV>On Nov 29, 2007, at 12:50 AM, Oliver Hunt wrote:</DIV><BLOCKQUOTE type="cite">Hurrah! I was going to look into that tonight -- alas i'm not a reviewer :(</BLOCKQUOTE><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Ah, but everyone is a reviewer:</DIV><DIV><A href="http://llvm.org/docs/DeveloperPolicy.html#reviews">http://llvm.org/docs/DeveloperPolicy.html#reviews</A></DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>If you feel familiar enough with the code to do a good job reviewing it, feel free to approve it. We rely on people exercising their own judgement to determine whether they are confident that a patch is ok. :)</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>-Chris</DIV><BR><BLOCKQUOTE type="cite"><DIV>--Oliver</DIV><DIV><BR><DIV><DIV>On 29/11/2007, at 12:47 AM, Christopher Lamb wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"> <DIV>This was preventing CodeGen for</DIV><DIV><BR class="webkit-block-placeholder"></DIV><DIV>int ary[] = {1, 2, 3, 4};</DIV><DIV><BR class="webkit-block-placeholder"></DIV><DIV>because the initializer's type was of the original decl's type with an element count of zero.</DIV><DIV><BR class="webkit-block-placeholder"></DIV><DIV><BR class="webkit-block-placeholder"></DIV><DIV>Index: Sema/SemaDecl.cpp</DIV><DIV>===================================================================</DIV><DIV>--- Sema/SemaDecl.cpp<SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN>(revision 44432)</DIV><DIV>+++ Sema/SemaDecl.cpp<SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN>(working copy)</DIV><DIV>@@ -727,8 +727,10 @@</DIV><DIV> // completed by the initializer. For example: </DIV><DIV> // int ary[] = { 1, 3, 5 };</DIV><DIV> // "ary" transitions from a VariableArrayType to a ConstantArrayType.</DIV><DIV>- if (!VDecl->isInvalidDecl() && (DclT != SavT))</DIV><DIV>+ if (!VDecl->isInvalidDecl() && (DclT != SavT)) {</DIV><DIV> VDecl->setType(DclT);</DIV><DIV>+ Init->setType(DclT);</DIV><DIV>+ }</DIV><DIV> </DIV><DIV> // Attach the initializer to the decl.</DIV><DIV> VDecl->setInit(Init);</DIV><BR><DIV> <SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><DIV>--</DIV><DIV>Christopher Lamb</DIV><DIV><BR class="khtml-block-placeholder"></DIV><BR class="Apple-interchange-newline"></SPAN></SPAN> </DIV><BR><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">_______________________________________________</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">cfe-commits mailing list</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</A></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</A></DIV> </BLOCKQUOTE></DIV><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">_______________________________________________</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">cfe-commits mailing list</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</A></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</A></DIV> </BLOCKQUOTE></DIV><BR></BODY></HTML>