<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><BR><DIV><DIV>On Sep 17, 2007, at 3:36 PM, Fariborz Jahanian wrote:</DIV><DIV><BR class="khtml-block-placeholder"></DIV><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">-Parser::DeclTy *Parser::ParseObjCMethodDecl(DeclTy *IDecl,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">- tok::ObjCKeywordKind& pi, </DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">+Parser::DeclTy *Parser::ParseObjCMethodDecl(tok::ObjCKeywordKind& pi, </DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <SPAN class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "> </SPAN><SPAN class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "> </SPAN><SPAN class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "> </SPAN> tok::TokenKind mType, SourceLocation mLoc) {</DIV></BLOCKQUOTE><BR><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">+ virtual DeclTy *ObjcBuildMethodDeclaration(tok::ObjCKeywordKind& pi,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN><SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN> SourceLocation MethodLoc,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN> tok::TokenKind MethodType, TypeTy *ReturnType,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN><SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN> ObjcKeywordDecl *Keywords, unsigned NumKeywords,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN><SPAN class="Apple-tab-span" style="white-space:pre"> </SPAN> AttributeList *AttrList);</DIV></BLOCKQUOTE></DIV><DIV><BR class="khtml-block-placeholder"></DIV></DIV>Looks good. Some comments...<DIV><BR class="khtml-block-placeholder"><DIV><DIV>- Why is "pi" passed by reference?</DIV><DIV>- The name ("pi") could be a little more descriptive:-)</DIV><DIV>- Since this argument is only needed for protocols, I would have preferred it be added to the end of the respective argument lists (with a default argument). This way, fewer clients would need to be aware of data that is protocol specific...</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>snaroff<BR><DIV><BR class="khtml-block-placeholder"></DIV></DIV></DIV></DIV></BODY></HTML>