[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Chris Hamilton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 25 06:01:54 PDT 2019


chrish_ericsson_atx added a comment.

@Szelethus, firstly, thank you for landing this change. I really appreciate it!   Secondly, apologies for misspelling your name earlier.  And lastly, thank you for your patient explanation of how to get the diffs updated correctly in a Phabricator review.  I think my mistake was that I made the change and the updates updates in a private branch, and not directly off master, and then duplicated the changes on master.  For one of those sets of changes, I amended the first commit with the second round of changes, and I think I confused myself by doing that.  In any case, lesson learned, and thank you again for your coaching!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66014/new/

https://reviews.llvm.org/D66014





More information about the cfe-commits mailing list