[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 22 17:07:28 PDT 2019


Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/fpga/FPGATidyModule.cpp:15
+
+
+using namespace clang::ast_matchers;
----------------
Unnecessary empty line.


================
Comment at: clang-tidy/fpga/FPGATidyModule.cpp:32
+
+} // namespace flocl
+
----------------
Wrong namespace in comment. Try to run Clang-tidy llvm-namespace-comment.


================
Comment at: clang-tidy/fpga/StructPackAlignCheck.cpp:10
+
+#ifndef MAX_ALIGN_POWER_OF_TWO
+#define MAX_ALIGN_POWER_OF_TWO 7
----------------
Should be  be constexpr.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66564/new/

https://reviews.llvm.org/D66564





More information about the cfe-commits mailing list