[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 22 13:51:33 PDT 2019


xbolva00 added a comment.

>> What was the motivation for firing on more than bare literals?

First patch supported diagnosing macros. There is no exact motivation why, simply “I just did it” to present working prototype. Based on review, things were adjusted.

Some reviewers wanted to keep full macro support, some didnt like diagnose ^ in macros. That case was removed.

I think nobody complained about macro as LHS/RHS.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66397/new/

https://reviews.llvm.org/D66397





More information about the cfe-commits mailing list