[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

In D66397#1640685 <https://reviews.llvm.org/D66397#1640685>, @xbolva00 wrote:

> >> I think adding parens and casts are fairly well-understood to suppress warnings.
>
> It should work here as well. #define ALPHA_OFFSET (3). Did anobody from Chromium try it?
>
> >> They have varying levels of C++ proficiency
>
> I consider things like hex decimals or parens to silence as a quite basic knowledge.


parens for sure, but I'm not aware of any other warning that behaves differently for ordinary and hex literals. What else is there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66397/new/

https://reviews.llvm.org/D66397