[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

Matthias Gehre via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 21 15:25:34 PDT 2019


mgehre added a comment.

In the false-positive example, after the `DerivedToBase`, we see a constructor call which I think is the copy constructor.

1. We should consider `MutableArrayRef` to be a gsl::Pointer according to the paper, because it publicly derives from one.
2. Also in the paper, the copy constructor does should copies the pset of the argument instead of making the pointer point at the argument.

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66486/new/

https://reviews.llvm.org/D66486





More information about the cfe-commits mailing list