[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 21 11:14:03 PDT 2019


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

LGTM with one minor nit!



================
Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:233-235
+  std::string ObjectName = Lexer::getSourceText(
+      CharSourceRange::getTokenRange(Call.getArgExpr(0)->getSourceRange()),
+      C.getSourceManager(), C.getASTContext().getLangOpts());
----------------
Mmm, this will need to be de-duplicated out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66423/new/

https://reviews.llvm.org/D66423





More information about the cfe-commits mailing list