[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

[Joel E. Denny via Phabricator via cfe-commits]

jdenny added a comment.

I want to be sure we're on the same page.  Due to the changes I just backed out, the following two examples now generate different code:

  int a = 0;
  #pragma omp target map(a)
  #pragma omp teams firstprivate(a)
    ;



  int a = 0;
  #pragma omp target teams firstprivate(a) map(a)
    ;

The difference is whether `a` is passed by reference (the first case) or value (the second case) to the offloading function.

Is that fine for you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65835/new/

https://reviews.llvm.org/D65835