[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 20 18:52:00 PDT 2019


Charusso marked an inline comment as done.
Charusso added inline comments.


================
Comment at: clang/test/Analysis/cast-value-notes.cpp:34
+  if (dyn_cast_or_null<Circle>(C)) {
+    // no-note: 'Assuming 'C' is a 'Circle', not a 'Circle''
+    return;
----------------
NoQ wrote:
> A circle is always a circle.
I have removed that contradiction test case as being silly, but yes, that was the `no-warning` test properly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66325/new/

https://reviews.llvm.org/D66325





More information about the cfe-commits mailing list