[PATCH] D59692: [ASTImporter] Fix name conflict handling

[Gabor Marton via Phabricator via cfe-commits]

martong marked 2 inline comments as done.
martong added inline comments.


================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:2392
 
+struct ImportFunctionTemplates : ASTImporterOptionSpecificTestBase {};
+
----------------
shafik wrote:
> What about tests for name conflicts for:
> 
> `NamespaceDecl` 
> `TypedefNameDecl`
> `TypeAliasTemplateDecl`
> `EnumConstantDecl`
> `RecordDecl`
> `VarDecl`
> 
> Who were also modified above.
I added several new tests with a new test suite `ConflictingDeclsTest`, they cover all the modifications in ASTImporter.cpp except for VarTemplateDecls.
In case of VarTemplateDecls we don't have a proper structural eq check implemented yet, so I disabled that test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59692/new/

https://reviews.llvm.org/D59692