[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

Diogo N. Sampaio via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 14 06:29:17 PDT 2019


dnsampaio added inline comments.


================
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:482-486
+  llvm::ARM::ArchKind ArchKind =
+      !ArchName.empty()
+          ? llvm::ARM::parseArch(arm::getARMArch(ArchName, Triple))
+          : llvm::ARM::parseCPUArch(
+                arm::getARMTargetCPU(CPUName, ArchName, Triple));
----------------
Could just use `llvm::ARM::ArchKind arm::getLLVMArchKindForARM(StringRef CPU, StringRef Arch,  const llvm::Triple &Triple)` ?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66018/new/

https://reviews.llvm.org/D66018





More information about the cfe-commits mailing list