[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()
Matthias Gehre via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 13 15:30:08 PDT 2019
mgehre marked an inline comment as done.
mgehre added inline comments.
Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:172
+ T &value();
> I actually was a bit lazy when I added these tests. Both `value` and `operator*` is overloaded on `&&`. But if you do not feel like adjusting the tests this is fine, I can do it myself later :)
I'll change it to use the `&` variant in the test - the `&&` cannot dangle as far as I understand.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits