[PATCH] D66152: Fix false negatives of statement local lifetime analysis for some STL implementation

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 13 10:34:54 PDT 2019

xazax.hun created this revision.
xazax.hun added reviewers: gribozavr, mgehre.
Herald added subscribers: Charusso, gamesh411, Szelethus, dkrupp, rnkovacs.
Herald added a project: clang.
xazax.hun marked an inline comment as done.
xazax.hun added inline comments.

Comment at: clang/lib/Sema/SemaInit.cpp:7130
-    bool IsGslPtrInitWithGslTempOwner =
-        IsTempGslOwner && pathOnlyInitializesGslPointer(Path);
+    bool IsGslPtrInitWithGslTempOwner = false;
+    bool IsLocalGslOwner = false;
This is the NFC part.

Some STL implementations have some class definitions (e.g. iterators) in a namespace outside of `std`.
This patch will extend the warnings from classes in `std` namespace to other implementation specified namespaces (that start with double underscored or underscore and a capital letter).

This patch also contains some NFC changes that supposed to make the code cleaner. If desired, I can split up this patch to two parts.

  rG LLVM Github Monorepo



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66152.214872.patch
Type: text/x-patch
Size: 4892 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190813/5dbf7092/attachment-0001.bin>

More information about the cfe-commits mailing list