[PATCH] D65994: Extended FPOptions with new attributes

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 12 23:14:51 PDT 2019


rjmccall added a comment.

Oh, sorry, I confused several patches, then.

I don't actually think you need to break down the patches this finely; it would be fine to take all three steps to implement the feature in one pass.  It's only important to break down the patches into more incremental components if there's significant refactoring required to prepare for the patch or if each step is substantially complex on its own.  And it's nice for feature work to always be testable *somehow*.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65994/new/

https://reviews.llvm.org/D65994





More information about the cfe-commits mailing list