[PATCH] D66068: cmake: Make building clang-shlib optional
Jan Vesely via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 12 13:43:48 PDT 2019
jvesely added a comment.
In D66068#1625478 <https://reviews.llvm.org/D66068#1625478>, @beanz wrote:
> I generally am not a fan of adding more and more options. As long as you're not linking the library it won't be generated by any of the check targets. With the llvm dylib we've had many issues over the years where changes to LLVM break building the dylib and many developers don't build it, so we have to wait for a bot to catch it. Making the clang dylib build as part of `all` in every possible build configuration is a recognition that this is something we ship and we should ensure works.
I've no problem with it staying ON by default. I just don't see a reason to make every minor modification rebuild last 5-6mins instead of 30s, for something I don't want, need or use.
Not everyone is a billion-dollar corporation with a dedicated build farm.
CHANGES SINCE LAST ACTION
More information about the cfe-commits