[PATCH] D65182: [analyzer] Add fix-it hint support.

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 9 19:22:00 PDT 2019


Charusso accepted this revision.
Charusso added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:103
   void enableWerror() { ShouldEmitAsError = true; }
+  void enableFixitsAsRemarks() { FixitsAsRemarks = true; }
 
----------------
NoQ wrote:
> Charusso wrote:
> > `FixIt` with capital `i`.
> It looks as if people write `FixIt` when they mean "fix-it" as an adjective (eg., "fix-it hint", "fix-it location") but `Fixit` when they mean "a fixit" as a noun.
The name of the stuff is `fix-it` as properly named in the title of the review and `fixit` is a total different noun. I do not mind, if we pick `fixit`, but the tooling will remain named as `fix-it`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65182/new/

https://reviews.llvm.org/D65182





More information about the cfe-commits mailing list