[PATCH] D65912: [clang-tidy] Add new check for math constants

Alexander Zaitsev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 9 10:37:21 PDT 2019


ZaMaZaN4iK added a comment.

> My point regarding statistics is that the check needs to pull its own weight -- if it doesn't find many true positives, it's not of much value to a broad community, or if it has a lot of false positives, we may need to tweak the check before releasing it to the public, etc. So definitely do the implementation work, but part of that work should be testing it over large code bases and reporting back the results.

Okay. Do we have any infrastructure for doing such testing? Or I should do it manually: prepare some large codebases, run over them clang-tidy with the check and parse the result?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65912/new/

https://reviews.llvm.org/D65912





More information about the cfe-commits mailing list