[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 9 07:02:57 PDT 2019


aganea added a comment.

In D65906#1622209 <https://reviews.llvm.org/D65906#1622209>, @arphaman wrote:

> @aganea These are not just any invisible characters that you have, this is the UTF8 BOM. Clang's Lexer skips over them if they're in the beginning of the file (`Lexer::InitLexer`). The minimizer should do the same thing, so ideally you would factor out the BOM detection and teach the minimizer to skip past it.


Thanks for the heads up. I'll do that.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65906/new/

https://reviews.llvm.org/D65906





More information about the cfe-commits mailing list