[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 8 15:48:11 PDT 2019


lebedev.ri added a comment.

In D64931#1622038 <https://reviews.llvm.org/D64931#1622038>, @akhuang wrote:

> @lebedev.ri The test case datalayout strings were changed because somewhere llvm asserts that the string in the IR matches the backend datalayout. I don't know why I wasn't getting the assert error now, but I think they'll all have to be changed


Can you post a reproducer?

In D64931#1622038 <https://reviews.llvm.org/D64931#1622038>, @akhuang wrote:

> if we change the X86 datalayout?


I think this is precisely what was discussed in replies to RFC - this hardcodes these address spaces,
and thus either makes them unavaliable for other front-ends and/or forces them to use them with Precisely Same Meaning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64931/new/

https://reviews.llvm.org/D64931





More information about the cfe-commits mailing list