[PATCH] D65978: [clang] Fixed x86 cpuid NSC signature

Louis Jacotot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 8 14:57:51 PDT 2019


Jacotot created this revision.
Jacotot added reviewers: teemperor, rsmith.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The signature "Geode by NSC" for NSC vendor is wrong.
In lib/Headers/cpuid.h, signature_NSC_edx and signature_NSC_ecx constants are inverted (cpuid signature order is ebx # edx # ecx).


Repository:
  rC Clang

https://reviews.llvm.org/D65978

Files:
  clang/lib/Headers/cpuid.h


Index: clang/lib/Headers/cpuid.h
===================================================================
--- clang/lib/Headers/cpuid.h
+++ clang/lib/Headers/cpuid.h
@@ -38,8 +38,8 @@
 #define signature_TM2_ecx 0x3638784d
 /* NSC:     "Geode by NSC" */
 #define signature_NSC_ebx 0x646f6547
-#define signature_NSC_edx 0x43534e20
-#define signature_NSC_ecx 0x79622065
+#define signature_NSC_edx 0x79622065
+#define signature_NSC_ecx 0x43534e20
 /* NEXGEN:  "NexGenDriven" */
 #define signature_NEXGEN_ebx 0x4778654e
 #define signature_NEXGEN_edx 0x72446e65


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65978.214242.patch
Type: text/x-patch
Size: 551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190808/a1319672/attachment.bin>


More information about the cfe-commits mailing list