[PATCH] D65912: [clang-tidy] Add new check for math constants

[Alexander Zaitsev via Phabricator via cfe-commits]

ZaMaZaN4iK added a comment.

The main reason why I've created this differential - asking to you about usefulness of this check for clang-tidy. I understand that there are a some TODO and formatting issues - it's ok for now.

As far I understand your remarks - you are not against this check so I can continue my work on this path. Great.

Let's discuss about some open questions:

1. Should we support C language and <math.h> header file? I think - yes, it's quite easy to implement.
2. Should we support converting to Boost.Constants? I don't think so.
3. In header file instead of defining math constants directly should we use them from <cmath> as much as possible?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65912/new/

https://reviews.llvm.org/D65912