[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

Thu Aug 8 12:10:50 PDT 2019

dcandler marked 5 inline comments as done.
dcandler added inline comments.

================
Comment at: clang/lib/Basic/Targets/ARM.cpp:938
+    // Thumb1: An immediate integer which is a multiple of 4 between 0 and 1020.
+    Info.setRequiresImmediate();
     return true;
----------------
compnerd wrote:
> Can we leave this as a FIXME?  This needs additional validation on the input.
I think it's not just the `M` constraint that requires additional validation. Most of these immediate constraints require values that can fit in specific encodings to be valid, or have properties like being a multiple of a number, but `setRequiresImmediate` at present can only check against a min/max or exact values.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65863/new/

https://reviews.llvm.org/D65863