[PATCH] D65690: [clang-doc] Add index in each info html file

Diego Astiazarán via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 5 19:51:14 PDT 2019


DiegoAstiazaran added inline comments.


================
Comment at: clang-tools-extra/clang-doc/Generators.cpp:79
+
+bool Generator::createResources(ClangDocContext &CDCtx) {
+  std::error_code OK;
----------------
juliehockett wrote:
> Why is this implementation in the generic Generator? It's fairly HTML-specific -- neither of the other generators are able to parse and include Javascript (since this does include the `var JsonIndex` bit).
Moved to HTMLGenerator.cpp; it was there because I was first writing a JSON file which could be used for any generator.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65690/new/

https://reviews.llvm.org/D65690





More information about the cfe-commits mailing list