[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 5 08:20:47 PDT 2019


ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous.
Herald added a project: clang.

We accumulated some configuration parameters for LookupVisibleDecls that
are being passed unchanged to recursive calls, e.g. LoadExternal and
IncludeDependentBases.

At the same time, there is a bunch of parameters that can change in the
recursive invocations.

It is hard to tell the difference between those groups, making the code
hard to follow.

This change introduces a helper struct and factors out the non-changing
bits into fields, making recursive calls in the implementation code easier
to read.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65752

Files:
  clang-tools-extra/clangd/IncludeFixer.cpp
  clang/lib/Sema/SemaLookup.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65752.213370.patch
Type: text/x-patch
Size: 27411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190805/c00be791/attachment-0001.bin>


More information about the cfe-commits mailing list