[PATCH] D64958: [clang-doc] Fix link generation

Jake Ehrlich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 2 12:24:09 PDT 2019

jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.

The code looks fine to me but I don't understand the global details of this. Hopefully Julie can still review things from there but if not we don't get timely reviews then we can still land this.

Comment at: clang-tools-extra/clang-doc/Representation.h:140-141
+  llvm::SmallString<128>
+      Path; // Path of directory where the clang-doc generated file will be
+            // saved (possibly unresolved)
+  bool IsInGlobalNamespace =
Here and below perhaps favor putting the comments above the line rather than to the side to make the formatter produce nicer looking code.

Comment at: clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp:83-84
   I.TagType = TagTypeKind::TTK_Class;
-  I.Parents.emplace_back(EmptySID, "F", InfoType::IT_record, "path/to/F");
+  I.Parents.emplace_back(EmptySID, "F", InfoType::IT_record,
+                         ""); // F is in the global namespace
   I.VirtualParents.emplace_back(EmptySID, "G", InfoType::IT_record,
Maybe put the comment above this line so that the formatter doesn't get all wonky.



More information about the cfe-commits mailing list