r367620 - Fix use-after-move in ClangBasicTests

Harlan Haskins via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 1 14:50:16 PDT 2019


Author: harlanhaskins
Date: Thu Aug  1 14:50:16 2019
New Revision: 367620

URL: http://llvm.org/viewvc/llvm-project?rev=367620&view=rev
Log:
Fix use-after-move in ClangBasicTests

Modified:
    cfe/trunk/unittests/Basic/FileManagerTest.cpp

Modified: cfe/trunk/unittests/Basic/FileManagerTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Basic/FileManagerTest.cpp?rev=367620&r1=367619&r2=367620&view=diff
==============================================================================
--- cfe/trunk/unittests/Basic/FileManagerTest.cpp (original)
+++ cfe/trunk/unittests/Basic/FileManagerTest.cpp Thu Aug  1 14:50:16 2019
@@ -212,6 +212,7 @@ TEST_F(FileManagerTest, getFileReturnsEr
   auto statCache = llvm::make_unique<FakeStatCache>();
   statCache->InjectDirectory(".", 41);
   statCache->InjectFile("foo.cpp", 42);
+  statCache->InjectDirectory("MyDirectory", 49);
   manager.setStatCache(std::move(statCache));
 
   // Create a virtual bar.cpp file.
@@ -221,7 +222,6 @@ TEST_F(FileManagerTest, getFileReturnsEr
   ASSERT_FALSE(file);
   ASSERT_EQ(file.getError(), std::errc::no_such_file_or_directory);
 
-  statCache->InjectDirectory("MyDirectory", 49);
   auto readingDirAsFile = manager.getFile("MyDirectory");
   ASSERT_FALSE(readingDirAsFile);
   ASSERT_EQ(readingDirAsFile.getError(), std::errc::is_a_directory);




More information about the cfe-commits mailing list