[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager
Chandler Carruth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 1 14:43:07 PDT 2019
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM with two nits addressed, thanks!
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1125
+ PB.addPGOInstrPassesForO0(MPM, CodeGenOpts.DebugPassManager,
+ /* RunProfileGen */ PGOOpt->Action ==
Minor nit, here and else where with the comment-named bools I'd use the style: `/*RunProfileGen=*/PGOOpt->Action == PGOOPtions::IRInstr`
This was suggested as more consistent w/ Clang style, and it seems a bit cleaner. Also, clang-tidy will recognize and check that the comment uses the same name as the parameter.
Comment at: llvm/lib/Passes/PassBuilder.cpp:1839
+ addPGOInstrPassesForO0(MPM, DebugLogging,
+ /* RunProfileGen */
+ PGOOpt->Action == PGOOptions::IRInstr,
Same nit about the parameter comments here.
CHANGES SINCE LAST ACTION
More information about the cfe-commits