[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 1 13:22:44 PDT 2019


Charusso added a subscriber: george.karpenkov.
Charusso added inline comments.


================
Comment at: clang/test/Analysis/loop-unrolling.cpp:349-353
 #ifdef DFS
-    clang_analyzer_numTimesReached(); // expected-warning {{10}}
+    clang_analyzer_numTimesReached(); // expected-warning {{16}}
 #else
-    clang_analyzer_numTimesReached(); // expected-warning {{13}}
+    clang_analyzer_numTimesReached(); // expected-warning {{8}}
 #endif
----------------
NoQ wrote:
> I'm mildly curious what happened here.
I will leave that comment not 'Done' as some kind of `FIXME: Measure the loop unrolling.`
But I believe these numbers supposed to be here from the start when @george.karpenkov made the traversing coverage-based (source: https://youtu.be/4n3l-ZcDJNY?t=540).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65587/new/

https://reviews.llvm.org/D65587





More information about the cfe-commits mailing list