[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Ah, omission of the century :/

Thanks, this looks immediately good!



================
Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:305
 
+  // The 'NodeBuilderContext::blockCount()'.
+  const unsigned BlockCount;
----------------
"The number of times the Block has been visited. Allows discriminating between stack frames of the same call that is called multiple times in a loop."


================
Comment at: clang/test/Analysis/loop-unrolling.cpp:349-353
 #ifdef DFS
-    clang_analyzer_numTimesReached(); // expected-warning {{10}}
+    clang_analyzer_numTimesReached(); // expected-warning {{16}}
 #else
-    clang_analyzer_numTimesReached(); // expected-warning {{13}}
+    clang_analyzer_numTimesReached(); // expected-warning {{8}}
 #endif
----------------
I'm mildly curious what happened here.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65587/new/

https://reviews.llvm.org/D65587