[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure
Harlan Haskins via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 31 16:30:16 PDT 2019
harlanhaskins added inline comments.
Comment at: clang/include/clang/Basic/FileManager.h:217
- /// This returns NULL if the file doesn't exist.
+ /// This returns a \c std::error_code if there was an error loading the file.
> harlanhaskins wrote:
> > jkorous wrote:
> > > Does that mean that it's now safe to assume the value is `!= NULL` in the absence of errors?
> > That's the intent of these changes, yes, but it should also be documented. 👍
> In line with the previous comment, should we just pass a reference then?
I'm fine with doing that, but it would introduce a significant amount more churn into this patch.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits