[PATCH] D65382: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 29 18:42:07 PDT 2019
NoQ added a comment.
It's counter-idiomatic to pass manager objects (`ProgramStateManager`, `SValBuilder`, etc.) as const-references because it tells you pretty much nothing about what you can or cannot do with them. You don't really ever semantically mutate them in the first place.
But when it comes to actual data structures such as `ExplodedGraph`, we should totally be doing this, yeah :)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits