[PATCH] D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach

Bjorn Pettersson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 28 11:07:50 PDT 2019


bjope added a comment.

In D65233#1603783 <https://reviews.llvm.org/D65233#1603783>, @thakis wrote:

> In D65233#1603741 <https://reviews.llvm.org/D65233#1603741>, @bjope wrote:
>
> > I made another fixup (similar to https://reviews.llvm.org/rL367176) here https://reviews.llvm.org/rL367182.
> >
> > Can someone please take a look (a post-commit review) of https://reviews.llvm.org/rL367182 to verify that I did not misunderstand the intention with the test somehow?
>
>
> Looks good. Thanks much for the fix!


Nice to know that I did not mess up the test in my attempt to silence the buildbots. So thanks for taking a look.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65233/new/

https://reviews.llvm.org/D65233





More information about the cfe-commits mailing list