[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 26 18:23:36 PDT 2019


NoQ marked an inline comment as done.
NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:157
   ClusterBindings::Factory *CBFactory;
+  bool IsMainAnalysis;
 
----------------
We could have put this flag into `RegionStoreManager` instead - after all, it doesn't change for the whole duration of the analysis. It would have made it easier to handle (avoid weird bitwise logic) and probably cheaper, but it'll make the manager needlessly stateful (which wouldn't really hurt at all right now, just looks ugly).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65361/new/

https://reviews.llvm.org/D65361





More information about the cfe-commits mailing list