[PATCH] D65003: [clang-doc] Add index in each info html file

[Julie Hockett via Phabricator via cfe-commits]

juliehockett added inline comments.


================
Comment at: clang-tools-extra/clang-doc/Generators.h:28
 
+  static Index genIndex(const std::vector<std::unique_ptr<Info>> &Infos);
+
----------------
Add a comment here indicating that this should be created before calling any `generateDocForInfo`s. Also add a fix-it note to the following effect:

`FIXME: This currently needs to be run before generating any individual documentation pages, since the content it generates is directly included in every page. A better design would be to lazily include it in the individual documentation pages, in which case this could be run in parallel with calls to generateDocForInfo().`


================
Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:337-346
+<ul>
+  <li><span>A</span></li>
+  <li><span>B</span><ul>
+  <li><span>C</span></li>
+</ul></li>
+  <li><span>D</span><ul>
+  <li><span>E</span><ul>
----------------
The indentation here seems a bit off


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65003/new/

https://reviews.llvm.org/D65003