[PATCH] D64958: [clang-doc] Fix link generation

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 25 08:49:47 PDT 2019


juliehockett added a comment.

Under what circumstances, exactly, is the path not set where you would need to create a link despite that? Is it only in the global namespace case? If so, could you special-case that and ignore other empty paths?



================
Comment at: clang-tools-extra/clang-doc/Representation.h:137
+            // saved (possibly unresolved)
+  bool IsPathValid = false; // Indicates if a value has been assigned to Path,
+                            // it could be an empty string
----------------
Is this field actually set anywhere? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64958/new/

https://reviews.llvm.org/D64958





More information about the cfe-commits mailing list