[PATCH] D60663: Time profiler: small fixes and optimizations

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 24 05:30:50 PDT 2019


sammccall added inline comments.


================
Comment at: llvm/trunk/lib/Support/TimeProfiler.cpp:27
 
+static cl::opt<unsigned> TimeTraceGranularity(
+    "time-trace-granularity",
----------------
anton-afanasyev wrote:
> sammccall wrote:
> > I know this is late, but... this shows up in the help for any tool that links in libSupport, many of which don't support the time profiler. Can you mark this as hidden or (preferably) move this to cc1_main?
> @sammccall Yes, thanks! Here is the fix https://reviews.llvm.org/D65202 , please, review it.
Thanks! A few nits but that's a big improvement I think.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60663/new/

https://reviews.llvm.org/D60663





More information about the cfe-commits mailing list